Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can paginate public room list is flaky #1044

Closed
richvdh opened this issue May 14, 2021 · 18 comments · Fixed by #1154 or #1262
Closed

Can paginate public room list is flaky #1044

richvdh opened this issue May 14, 2021 · 18 comments · Fixed by #1154 or #1262
Labels
Z-Flaky Tests which seem to fail at random

Comments

@richvdh
Copy link
Member

richvdh commented May 14, 2021

https://github.com/matrix-org/synapse/pull/9981/checks?check_run_id=2582973111
@richvdh richvdh added the Z-Flaky Tests which seem to fail at random label May 14, 2021
@richvdh
Copy link
Member Author

richvdh commented May 14, 2021

and https://buildkite.com/matrix-dot-org/synapse/builds/17339#650a0408-a6ac-4d1b-8823-b26e43d0a379

@clokep
Copy link
Member

clokep commented Aug 10, 2021

And https://github.com/matrix-org/synapse/pull/10574/checks?check_run_id=3293529951

@richvdh
Copy link
Member Author

richvdh commented Oct 6, 2021

and https://github.com/matrix-org/sytest/pull/1149/checks?check_run_id=3817819072

@DMRobertson
Copy link
Contributor

and https://github.com/matrix-org/synapse/runs/3826760651?check_suite_focus=true

@DMRobertson DMRobertson self-assigned this Oct 7, 2021
@DMRobertson DMRobertson mentioned this issue Oct 7, 2021
Merged
@DMRobertson
Copy link
Contributor

Reproducing it locally with

docker run --rm -v /home/dmr/workspace/synapse:/src:ro -v /home/dmr/workspace/sytest/:/sytest -v /tmp/logs:/logs -e POSTGRES=1 -e WORKERS=1 -e MULTI_POSTGRES=1 matrixdotorg/sytest-synapse:testing --torture-replication 100 -s tests/30rooms/70publicroomslist.pl

@DMRobertson DMRobertson mentioned this issue Oct 7, 2021
Merged
@DMRobertson DMRobertson mentioned this issue Nov 3, 2021
Merged
@DMRobertson
Copy link
Contributor

This showed up twice today.

https://github.com/matrix-org/sytest/runs/4091934326?check_suite_focus=true
https://github.com/matrix-org/sytest/runs/4091934326?check_suite_focus=true

both in #1116. I couldn't see any changes there or in the linked Synapse branch which would explain this.

@DMRobertson DMRobertson reopened this Nov 3, 2021
@ShadowJonathan
Copy link
Contributor

Another run in https://github.com/matrix-org/synapse/runs/4447433909?check_suite_focus=true

@clokep
Copy link
Member

clokep commented Jan 13, 2022

Seen again: https://github.com/matrix-org/synapse/runs/4805751717

@DMRobertson DMRobertson removed their assignment Feb 8, 2022
@clokep
Copy link
Member

clokep commented Feb 11, 2022

https://github.com/matrix-org/synapse/runs/5160171515?check_suite_focus=true

@clokep
Copy link
Member

clokep commented Feb 15, 2022

https://github.com/matrix-org/synapse/runs/5199772896?check_suite_focus=true

@clokep clokep mentioned this issue Feb 15, 2022
Merged
@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/runs/6076311915?check_suite_focus=true

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/runs/6193058369?check_suite_focus=true

@DMRobertson DMRobertson mentioned this issue Apr 27, 2022
Merged
@clokep
Copy link
Member

clokep commented May 4, 2022

And https://github.com/matrix-org/synapse/runs/6287201691?check_suite_focus=true

@DMRobertson
Copy link
Contributor

DMRobertson commented May 9, 2022 •
edited
Loading

https://github.com/matrix-org/synapse/runs/6346842207?check_suite_focus=true

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/runs/6739724836?check_suite_focus=true

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/runs/6899135826?check_suite_focus=true

@richvdh
Copy link
Member Author

richvdh commented Jun 17, 2022

https://github.com/matrix-org/synapse/runs/6932637886?check_suite_focus=true

@richvdh
Copy link
Member Author

richvdh commented Jun 17, 2022

Pretty sure this is just timing out. It creates 10 rooms, which takes 10 seconds, which is the default test timeout.

See also matrix-org/synapse#6068

richvdh added a commit that referenced this issue Jun 17, 2022
@richvdh
Increase the timeout on a test, to stop it failing
7c876c4 
Fixes #1044
@richvdh richvdh mentioned this issue Jun 17, 2022
Merged
richvdh added a commit that referenced this issue Jun 17, 2022
@richvdh
Increase the timeout on a test, to stop it failing (#1262)
5fd0283 
Fixes #1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Flaky Tests which seem to fail at random
Projects
None yet
Milestone
No milestone
4 participants
@clokep @richvdh @DMRobertson @ShadowJonathan