Fix 'Backfilled events whose prev_events are in a different...' test #1059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in matrix-org/synapse#10272, where we made incoming federation event processing asynchronous.
The failure mode was that when we called
await_sync_timeline_contains
it would get eventR
and then separatelyS
, where previously we'd get them down in the same batch, and so paginating from theprev_batch
token returnedR
rather than justQ
. This didn't happen previously as the call tosend_event
previously took long enough that by the time the test calledawait_sync_timeline_contains
the server would have process bothR
andS
and so they'd come down in the same batch.After this has landed we should remove the test from the blacklist.