Don't install dependencies from git when running Synapse in offline mode #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used `--no-index` to prevent use of PyPI in offline mode, but that did not apply to git dependencies. Add the `--no-deps` flag to prevent pip from re-cloning those. At this time, the only git dependency we might have is twisted trunk during a daily CI run. Signed-off-by: Sean Quah <seanq@element.io>
DMRobertson
approved these changes
Apr 21, 2022
|
sytest failure appears to be #1130 ? |
squahtx
deleted the
squah/dont_install_git_dependencies_during_synapse_offline_install
branch
squahtx
restored the
squah/dont_install_git_dependencies_during_synapse_offline_install
branch
squahtx
deleted the
squah/dont_install_git_dependencies_during_synapse_offline_install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
--no-indexto prevent use of PyPI in offline mode,but that did not apply to git dependencies. Add the
--no-depsflagto prevent pip from re-cloning those.
At this time, the only git dependency we might have is twisted trunk
during a daily CI run.
Signed-off-by: Sean Quah seanq@element.io
Fixes matrix-org/synapse#12517, hopefully (untested).