Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that remote device list is refetched on leave/rejoin #793

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Test that remote device list is refetched on leave/rejoin #793

merged 6 commits into from
Feb 6, 2020

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 29, 2020 •
edited
Loading

@erikjohnston erikjohnston requested a review from a team January 30, 2020 17:37
richvdh
richvdh previously requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new test itself looks fine. the other stuff which doesn't seem to be immediately related to the new test, less so.

lib/SyTest/Federation/Client.pm Outdated Show resolved Hide resolved
tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
erikjohnston and others added 2 commits January 31, 2020 11:49
@erikjohnston @richvdh
Update tests/50federation/40devicelists.pl
ff5c2e2 
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@erikjohnston
Add back v1 endpoint code
40b523c
@erikjohnston
Copy link
Member Author

Ok, I've tried to move stuff back to not relying on /v2 being called. I don't know if adding a new await_request_v1_send_join_reject_v2 is the right approach going forwards, but it at least works for now

richvdh
richvdh approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I think

lib/SyTest/Federation/Server.pm Outdated Show resolved Hide resolved
tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
@erikjohnston erikjohnston merged commit 4172585 into develop Feb 6, 2020
anoadragon453 added a commit that referenced this pull request Mar 23, 2020
@anoadragon453
Merge commit '86ceaf920b21c4405794c867d60ad13552fec98e' into dinsic-r…
66f1c69 
…elease-v1.10.x

* commit '86ceaf920b21c4405794c867d60ad13552fec98e':
  Update tests that assumed PL50 for room upgrade, fix others (#805)
  Test /user/devices/ on fed reader (#799)
  Update tests to match removal of Synapse sending events when creating or deleting aliases.
  Route GET /groups queries to workers (#798)
  Don't push Dendrite images to Docker Hub (#797)
  Test that remote device list is refetched on leave/rejoin (#793)
  Update build.sh
  Update dendrite.Dockerfile
  Apply suggestions from code review
  add test for device key signatures over federation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh