-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for validating alt_aliases of a canonical alias event. #824
Conversation
123148e
to
e313682
Compare
e313682
to
e68180b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Good thing I added those -- I realized one of the tests was hitting a different condition than I thought. I added an additional test, so I'm going to request review again. |
be1d098
to
7afa389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
…ease-v1.12.x * origin/release-v1.12.0: Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) Add tests for validating alt_aliases of a canonical alias event. (#824) Update the haproxy config to route fallback auth and register to the same worker. (#828) Add tests for a user with sufficient power level removing an alias. (#818) Add a test for an event with an invalid signature (#821) Fix race in self signing key tests. (#822) Use retry_until_success instead of repeat_until_true. Attempt to deflake a test. Fix frontend proxy worker binding to wrong port. (#823) Stop checking for aliases in the public room list. Attempt to deflake a sytest (#816) Fix formatting from review. Support running Dendrite in more than 1 sqlite db file Add tests for moving alt_aliases to an upgraded room. Support running dendrite in sqlite
This adds tests for the behavior for validating the
alt_aliases
field of a canonical alias event added to Synapse in matrix-org/synapse#6971.