Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to YAML::XS for YAML serialisation #888

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Switch to YAML::XS for YAML serialisation #888

merged 1 commit into from
Jun 12, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 12, 2020

it's better at understanding the difference between 1, true, and
"true". This leads to a few fixes around the codebase where it turned out we
were getting away with some sloppiness thanks to YAML's idiosyncracies.

it's better at understanding the difference between `1`, `true`, and
`"true"`. This leads to a few fixes around the codebase where it turned out we
were getting away with some sloppiness thanks to `YAML`'s idiosyncracies.
Comment on lines +2 to +3
server-0/
server-1/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kinda unrelated but was something I came across when trying to rebuild the docker images to include YAML::XS.

@@ -18,7 +18,7 @@ use File::Path qw( remove_tree );
use List::Util qw( any );
use POSIX qw( strftime WIFEXITED WEXITSTATUS );

use YAML ();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused.

@@ -410,9 +410,8 @@ sub generate_listeners
type => "http",
port => $unsecure_port,
bind_address => $bind_host,
tls => 0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tls and compress are both disabled by default.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Straight from their docs they say to use YAML::XS too:

If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time.

@richvdh richvdh merged commit 7e8c859 into develop Jun 12, 2020
@richvdh richvdh deleted the rav/yaml_xs branch June 12, 2020 17:31
valkum added a commit to valkum/sytest that referenced this pull request Jul 14, 2020
anoadragon453 added a commit that referenced this pull request Aug 4, 2020
* origin/release-v1.15.2:
  Unbreak dendrite build; use json true
  Switch to YAML::XS for YAML serialisation (#888)
  Add DENDRITE_TRACE_INTERNAL
valkum added a commit to valkum/sytest that referenced this pull request Aug 26, 2020
valkum added a commit to valkum/sytest that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants