-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Synapse and MSC2716 edits (explore the DAG) #1
Open
MadLittleMods
wants to merge
3
commits into
matrix-org:main
Choose a base branch
from
MadLittleMods:2716-tardis-synapse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits to make TARDIS work with Synapse while writing Complement tests for [MSC 2716](matrix-org/matrix-spec-proposals#2716). - matrix-org/synapse#9247 - matrix-org/complement#68
MadLittleMods
commented
Feb 2, 2021
@@ -0,0 +1,629 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Feb 2, 2021
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Feb 2, 2021
Also edits for TARDIS visualation: matrix-org/tardis#1
MadLittleMods
changed the title
Draft: Synapse and MSC2716 edits
Draft: Synapse and MSC2716 edits (explore the DAG)
Feb 2, 2021
MadLittleMods
commented
Feb 2, 2021
@@ -259,7 +313,9 @@ window.onload = async (event) => { | |||
|
|||
// Add text to nodes with border | |||
nodes.append('text') | |||
.text((d) => d.data.type) | |||
.text((d) => { | |||
return `${d.data.type} - ${d.data.content && d.data.content.body} (depth=${d.data.depth})`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated DAG visualization with depth. See matrix-org/complement#68 (comment) for full context
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Feb 5, 2021
Merged
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits to make TARDIS work with Synapse while writing Complement tests for MSC2716.
Changes needed in Synapse
In Synapse, comment out all of the dropped fields in the event serialization in Synapse
synapse/events/utils.py#L253-L259
.Changes needed in your Complement test
Previous before functional client API
Copy the output of that log line and paste it in the
src/context-response.json
file. (Replace the\"
with"
)