Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Split out the CI setups for mutation testing #152

Merged
merged 2 commits into from
May 6, 2024

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented May 6, 2024

This patch attempts to limit the times we run the full mutation tests. The full tests take 1h to complete so it's not feasible to run them as part of a pull-request CI job.

The original setup did attempt to limit this as well, but pushing additional commits to a pull request did trigger the full run as well.

@poljar poljar requested a review from dkasak as a code owner May 6, 2024 10:04
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (3b1ac68) to head (ceb0ce2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   90.32%   90.37%   +0.05%     
==========================================
  Files          32       32              
  Lines        1788     1787       -1     
==========================================
  Hits         1615     1615              
+ Misses        173      172       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a nit.

.github/workflows/mutants.yml Outdated Show resolved Hide resolved
poljar added 2 commits May 6, 2024 13:13
This patch attempts to limit the times we run the full mutation tests.
The full tests take 1h to complete so it's not feasible to run them as
part of a pull-request CI job.

The original setup did attempt to limit this as well, but pushing
additional commits to a pull request did trigger the full run as well.
@poljar poljar force-pushed the poljar/mutation-test-fix branch from ceb0ce2 to 47ef7a1 Compare May 6, 2024 11:13
@poljar poljar merged commit 2db3735 into main May 6, 2024
33 checks passed
@poljar poljar deleted the poljar/mutation-test-fix branch May 6, 2024 11:17
@Urgau
Copy link

Urgau commented May 24, 2024

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Footnotes

  1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below

@poljar
Copy link
Collaborator Author

poljar commented May 24, 2024

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Ah nice, thanks for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants