Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the ZeroizeOnDrop trait instead of the deprecated drop call #159

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented Jul 12, 2024

No description provided.

@poljar poljar requested a review from dkasak as a code owner July 12, 2024 12:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (3e9866b) to head (9190664).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          34       34           
  Lines        1909     1909           
=======================================
  Hits         1729     1729           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poljar poljar enabled auto-merge (rebase) July 17, 2024 10:41
@poljar poljar disabled auto-merge July 17, 2024 10:41
Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poljar poljar merged commit 771d1c2 into main Jul 17, 2024
33 checks passed
@poljar poljar deleted the poljar/zeroize-update branch July 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants