Add an editorconfig and vscode settings #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 34 34
Lines 1907 1907
=======================================
Hits 1723 1723
Misses 184 184 ☔ View full report in Codecov by Sentry. |
The editorconfig and vscode settings for rust-analyzer have been established as cross-editor settings. At least nvim and vscode itself support them and people often times have trouble with our cargo fmt settings which require nightly. This way, if a supported editor is used, no additional setup is required by the contributor.
poljar
force-pushed
the
poljar/add-editorconfig
branch
from
66d9068
to
7164e0f
Compare
dkasak
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editorconfig and vscode settings for rust-analyzer have been established as cross-editor settings. At least nvim and vscode itself support them and people often times have trouble with our cargo fmt settings which require nightly.
This way, if a supported editor is used, no additional setup is required by the contributor.