Merge pull request #43 from matt-ball/fail-check

guard setFailed
matt-ball · Oct 11, 2021 · 573e42a · 573e42a
2 parents e28dce0 + a296a70
commit 573e42a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -254297,7 +254297,9 @@ function removeEmpty (obj) {
 
 function runNewman (options) {
   newman.run(options, (err) => {
-    core.setFailed('Newman run failed! ' + (err || ''))
+    if (err) {
+      core.setFailed('Newman run failed! ' + (err || ''))
+    }
   }).on('done', (err, summary) => {
     if (!options.suppressExitCode && (err || summary.run.failures.length)) {
       core.setFailed('Newman run failed! ' + (err || ''))

diff --git a/index.js b/index.js
@@ -94,7 +94,9 @@ function removeEmpty (obj) {
 
 function runNewman (options) {
   newman.run(options, (err) => {
-    core.setFailed('Newman run failed! ' + (err || ''))
+    if (err) {
+      core.setFailed('Newman run failed! ' + (err || ''))
+    }
   }).on('done', (err, summary) => {
     if (!options.suppressExitCode && (err || summary.run.failures.length)) {
       core.setFailed('Newman run failed! ' + (err || ''))

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "newman-action",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Run Postman collections with Newman as a GitHub Action",
   "main": "dist/index.js",
   "repository": {