Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State ON for climate entities #278

Closed
anarion80 opened this issue Jan 25, 2024 · 0 comments · Fixed by #283
Closed

State ON for climate entities #278

anarion80 opened this issue Jan 25, 2024 · 0 comments · Fixed by #283
Labels
bug Something isn't working

Comments

@anarion80
Copy link
Contributor

I think there is a potential bug in how climate entities state is determined - or it might be a 'feature' of my climate integration (https://github.com/mariusz-ostoja-swierczynski/tech-controllers).

From HA docs:

hvac_mode - The current operation (e.g. heat, cool, idle). Used to determine state.

while:

hvac_action - The current HVAC action (heating, cooling)

So climate entity state is not really current state.... And all my climate entities (with hvac_mode === heat) are shown as ON in HA Fusion and there is no difference at all when they are Idle or actually currently heating.

I think for climate entities the actual state for the button should be determined from hvac_action.

Perhaps the following:

Name Description
HVACMode.HEAT The device is set to heat to a target temperature.
HVACMode.COOL The device is set to cool to a target temperature.
HVACMode.HEAT_COOL The device is set to heat/cool to a target temperature range.
HVACMode.AUTO The device is set to a schedule, learned behavior, AI.
HVACMode.DRY The device is set to dry/humidity mode.
HVACMode.FAN_ONLY The device only has the fan on. No heating or cooling taking place.

should be removed from onStates store and some specific condition added to https://github.com/matt8707/ha-fusion/blob/main/src/lib/Main/Button.svelte to determine climate state.

I can take a stab at a PR if this is real issue (not limited to my old integration).

@matt8707 matt8707 added the bug Something isn't working label Jan 25, 2024
anarion80 added a commit to anarion80/ha-fusion that referenced this issue Jan 25, 2024
matt8707 added a commit that referenced this issue Jan 28, 2024
Fix for ON states for climate entities #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants