Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Cover modal #57

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Implemented Cover modal #57

merged 2 commits into from
Jan 2, 2024

Conversation

fabianluque
Copy link
Contributor

No description provided.

@matt8707
Copy link
Owner

matt8707 commented Jan 2, 2024

Great!

I'm trying it with demo entities and i get reverse value of slider, do you know why?

current_position: 10
friendly_name: Hall Window
supported_features: 15

screen

@fabianluque
Copy link
Contributor Author

fabianluque commented Jan 2, 2024

Yes, tried to mimic HA modal behavior, they show full bar when 0% and empty bar when 100%. This is 100% for example:

image

Can be changed of course, just let me know what makes more sense.

@matt8707
Copy link
Owner

matt8707 commented Jan 2, 2024

I don't think it's logical for the bar to be filled to 90% while the state indicates 10%. What exactly does 'position' mean? Is position 0 'fully open and not covered,' and position 100 'fully closed/covered'?

@fabianluque
Copy link
Contributor Author

100% is fully open, 0% is fully closed

@matt8707
Copy link
Owner

matt8707 commented Jan 2, 2024

Okay, at position 100, it is 100% open. At position 0, it is 0% open.

The confusion seems to arise because they are mimicking the physical cover positions in a vertical orientation. I think we should do it like light brightness slider for consistency, unless you have any objections. 😊

@fabianluque
Copy link
Contributor Author

No objections, just pushed an update.

@matt8707
Copy link
Owner

matt8707 commented Jan 2, 2024

Thanks!

@matt8707 matt8707 merged commit d496435 into matt8707:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants