Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV when deleting copied profile #38

Closed
frickler24 opened this issue Jan 21, 2017 · 5 comments
Closed

SIGSEGV when deleting copied profile #38

frickler24 opened this issue Jan 21, 2017 · 5 comments
Assignees
Milestone

Comments

@frickler24
Copy link
Collaborator

This Issue is for me to remember. But if someone is faster than me :-)
Scenario is as follows:

  1. open ckb
  2. duplicate one of the profiles on the left (tested with KB K95RGB)
  3. delete the upper one of the two siblings
  4. crash.
    Crash-protocol from gdb ist here:
    Absturz-beim-Profillöschen.txt
    It is reproducable an error (nil-ptr) somewhere in the button-handler (action).
@tatokis
Copy link
Collaborator

tatokis commented Jan 21, 2017

While trying to reproduce yours, I stumbled upon another SIGSEGV.

All I did was go to "manage profiles" and then right click -> duplicate the first profile.

(gdb) bt
#0  0x00007ffff6a50de0 in qHash(QUuid const&, unsigned int) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#1  0x0000000000451fdb in QHash<QUuid, AnimScript*>::findNode(QUuid const&, unsigned int*) const ()
#2  0x000000000044a7fb in AnimScript::copy(QObject*, QUuid const&) ()
#3  0x00000000004550b4 in KbAnim::KbAnim(QObject*, KeyMap const&, KbAnim const&) ()
#4  0x000000000044010e in KbLight::KbLight(KbMode*, KeyMap const&, KbLight const&) ()
[...]

@frickler24
Copy link
Collaborator Author

@tatokis I tried a bit to produce your error but I couldn't produce it.
Is the first profile you try to duplicate marked as "saved to HW"? How many profiles do you have?
Anyhow, I'll have a look at it when debugging. Thanks!
@mattanger could you plz mark this issue as a bug?

@frickler24
Copy link
Collaborator Author

@tatokis I've found the reason for the bug as I described it.
Despite a lot of tests, I could not reproduce the behavior your mentioned above.
Do you have any more hints?

@frickler24 frickler24 self-assigned this Feb 14, 2017
@ghost
Copy link

ghost commented Feb 26, 2017

@tatokis I wasn't able to reproduce it on Ubuntu 16.10 with different combinations (saved into HW, not saved etc.).
However, I managed to reproduce this one by @frickler24. Will try a patch from a new PR.

UPD. the patch worked for me. I still wasn't able to reproduce your case.

ghost pushed a commit that referenced this issue Mar 4, 2017
Merge branch 'frickler24-testing-issue-38-SIGSEGV_when_deleting_copied_profile' into testing
* fixes #38
ghost pushed a commit that referenced this issue Mar 4, 2017
Merge branch
'frickler24-testing-issue-38-SIGSEGV_when_deleting_copied_profile'
into testing

* fixes #38
ghost pushed a commit that referenced this issue Mar 4, 2017
Merge branch
'frickler24-testing-issue-38-SIGSEGV_when_deleting_copied_profile'
into testing
@ghost
Copy link

ghost commented Mar 4, 2017

I have no idea why it didn't close the issue, maybe it closes it only when the header contains a notice and not the body, or because I force pushed a few times (sorry).

@ghost ghost closed this as completed Mar 4, 2017
@ghost ghost added the resolved label Apr 10, 2017
@ghost ghost added this to the 0.2.8 milestone Apr 10, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants