Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive Listing data in JsonModel.toString() #14

Closed
mattbdean opened this issue Oct 1, 2014 · 5 comments
Closed

More descriptive Listing data in JsonModel.toString() #14

mattbdean opened this issue Oct 1, 2014 · 5 comments

Comments

@mattbdean
Copy link
Owner

In JsonModel's toString() method, if a return value of a @JsonInteraction method is a subclass of JsonModel, the representation of that model is printed as "[ClassName]". For example:

CustomModel {getFoo()="Object@12345", getListing()=[Listing]}

This isn't very descriptive. It would be a lot more helpful if Listings were viewed as Listing[size] or some other variant.

A sample output could look like this:

CustomModel {getFoo()="Object@12345", getListing()={Listing getSize()="25"}}
@mtt88
Copy link
Contributor

mtt88 commented Oct 1, 2014

I'm happy to be assigned this issue.

@mattbdean
Copy link
Owner Author

I would be happy to accept a pull request.

@mtt88
Copy link
Contributor

mtt88 commented Oct 1, 2014

I ask to be assigned to prevent multiple people working on the same issue as I will not be able to pick this up until the weekend.

Matt

@mattbdean
Copy link
Owner Author

I see. However, there is currently no way to assign an issue to someone without giving them full write access.

I created an "assigned" label as a temporary fix so others will know not to fix this issue. You also mentioned fixing #4 some time ago. Is this still the case?

@mtt88
Copy link
Contributor

mtt88 commented Oct 2, 2014

I was not aware of the restriction on assigning Github issues. My misunderstanding. In future I'll just send the PR ;)

Yes please assign this issue to me.

Matt

2xsaiko pushed a commit to 2xsaiko/JRAW-saidit that referenced this issue Apr 14, 2019
Implement subreddit and site rules (for report reasons)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants