Skip to content
This repository has been archived by the owner on May 16, 2021. It is now read-only.

on release notes update are version dates overwritten to current date #39

Open
typekpb opened this issue Aug 23, 2017 · 7 comments
Open
Labels

Comments

@typekpb
Copy link

typekpb commented Aug 23, 2017

I've applied chandler on the project and noticed that all the dates are now overwritten with the date of update.

Is there a chance to fix it?

Current text says:

[username] released this 2 days ago · [XY] commits to master since this release

The problem is, that I introduced it to the project couple ears old (also with releases couple years old), but it seems these were released only couple days back.

I'd appreciate a chance to take the release date from the relese notes (as we have it there anyway).

@mattbrictson
Copy link
Owner

Thanks for the report. Unfortunately I don't think there is a way to edit the date of a GitHub release. The API docs do not mention dates at all in the create and update commands:

https://developer.github.com/v3/repos/releases/#create-a-release

I am open to suggestions but I can't figure out a way to do it.

@typekpb
Copy link
Author

typekpb commented Aug 23, 2017 via email

@typekpb
Copy link
Author

typekpb commented Aug 23, 2017 via email

@mattbrictson
Copy link
Owner

Chandler already tries to update an existing release if it is present:

def create_or_update_release(tag:, title:, description:)
return if config.dry_run?
release = existing_release(tag)
return update_release(release, title, description) if release
create_release(tag, title, description)
rescue Octokit::NotFound
raise InvalidRepository, repository
end

Do you have any guesses as to why is not working for your particular case?

@mattbrictson
Copy link
Owner

As an experiment, I re-ran this command on the Chandler repository after making some edits to the CHANGELOG:

$ chandler push v0.7.0
Push v0.7.0… ✔ 0.423s

The release notes at GitHub were updated, but the date did not change. It still says Dec 23, 2016.

https://github.com/mattbrictson/chandler/releases/tag/v0.7.0

So perhaps the problem only exists for new releases. I.e. you had a tag that existed for a long time but never created an actual release for it. Then when Chandler runs it creates a release for that tag, and the release is marked with today's date.

Does that sound like a plausible explanation of what you're running into?

@typekpb
Copy link
Author

typekpb commented Aug 23, 2017 via email

@mattbrictson
Copy link
Owner

⚠️ This project is no longer actively maintained. I have found myself embracing tools like release-drafter to keep release notes updated automatically, rather than relying on a manually edited CHANGELOG.md. If you are interested in taking over chandler development, let me know by opening an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants