Skip to content

Commit

Permalink
Update rubocop requirement from 1.57.2 to 1.58.0 (#19)
Browse files Browse the repository at this point in the history
* Update rubocop requirement from 1.57.2 to 1.58.0

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.57.2...v1.58.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply latest RuboCop suggestions

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Brictson <matt@mattbrictson.com>
  • Loading branch information
dependabot[bot] and mattbrictson authored Dec 1, 2023
1 parent 7717a6e commit 085ccd0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ gemspec
gem "minitest", "~> 5.11"
gem "minitest-reporters", "~> 1.3"
gem "rake", "~> 13.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.58.0"
gem "rubocop-minitest", "0.33.0"
gem "rubocop-packaging", "0.5.2"
gem "rubocop-performance", "1.19.1"
Expand Down
4 changes: 2 additions & 2 deletions lib/nextgen/actions/git.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def say_git(message)
def apply_as_git_commit(path, message: nil)
say message, :cyan if message
@commit_messages = []
initially_clean = (git_working? && git_status == :clean)
initially_clean = git_working? && git_status == :clean
say_status :apply, File.basename(path)
apply path, verbose: false
return if !initially_clean || git_status == :clean
Expand All @@ -35,7 +35,7 @@ def git_commit_all(msg)
def git_working?
return @git_working if defined?(@git_working)

@git_working = (git_status != :error && git_user_configured?)
@git_working = git_status != :error && git_user_configured?
end

def git_user_configured?
Expand Down
2 changes: 1 addition & 1 deletion template/app/controllers/concerns/basic_auth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def require_basic_auth
return true if expected_username.blank? || expected_password.blank?

authenticate_or_request_with_http_basic do |username, password|
ActiveSupport::SecurityUtils.secure_compare(username, expected_username) & \
ActiveSupport::SecurityUtils.secure_compare(username, expected_username) &
ActiveSupport::SecurityUtils.secure_compare(password, expected_password)
end
end
Expand Down

0 comments on commit 085ccd0

Please sign in to comment.