Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Gemfile.lock after adding Gemfile ruby declaration #120

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

mattbrictson
Copy link
Owner

Rails no longer includes a ruby declaration in the generated Gemfile. When nextgen adds it, a side-effect is that the Gemfile.lock will change the next time bundle install is run. This means that after generating a project, when you run bin/setup for the first time, it may cause the Gemfile.lock to change.

Fix by proactively running bundle lock and committing the result, so that the Gemfile.lock in the generated project is guaranteed to be up to date.

Rails no longer includes a `ruby` declaration in the generated Gemfile.
When nextgen adds it, a side-effect is that the Gemfile.lock will change
the next time `bundle install` is run. This means that after generating
a project, when you run `bin/setup` for the first time, it may cause
the Gemfile.lock to change.

Fix by proactively running `bundle lock` and committing the result, so
that the Gemfile.lock in the generated project is guaranteed to be up to
date.
@mattbrictson mattbrictson added automerge Automatically merge PR once all required checks pass 🐛 Bug Fix Fixes a bug labels Sep 29, 2024
@kodiakhq kodiakhq bot merged commit 89cfe5e into main Sep 29, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the bundle-lock branch September 29, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all required checks pass 🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant