fix: N-04 Unsafe ABI Encoding

matter-labs · Oct 25, 2024 · b826864 · b826864
1 parent fcec3d3
commit b826864
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/l1-contracts/contracts/governance/PermanentRestriction.sol b/l1-contracts/contracts/governance/PermanentRestriction.sol
@@ -235,7 +235,7 @@ contract PermanentRestriction is IRestriction, IPermanentRestriction, Ownable2St
 
         // Note, that we do not use an explicit call here to ensure that the function does not panic in case of
         // incorrect `_chain` address.
-        (bool success, bytes memory data) = _chain.staticcall(abi.encodeWithSelector(IGetters.getChainId.selector));
+        (bool success, bytes memory data) = _chain.staticcall(abi.encodeCall(IGetters.getChainId));
         if (!success || data.length < 32) {
             revert NotAHyperchain(_chain);
         }

diff --git a/l1-contracts/contracts/upgrades/GatewayUpgrade.sol b/l1-contracts/contracts/upgrades/GatewayUpgrade.sol
@@ -50,7 +50,7 @@ contract GatewayUpgrade is BaseZkSyncUpgrade, Initializable {
         );
         // slither-disable-next-line controlled-delegatecall
         (bool success, ) = THIS_ADDRESS.delegatecall(
-            abi.encodeWithSelector(IGatewayUpgrade.upgradeExternal.selector, proposedUpgrade)
+            abi.encodeCall(IGatewayUpgrade.upgradeExternal, proposedUpgrade)
         );
         // solhint-disable-next-line gas-custom-errors
         require(success, "GatewayUpgrade: upgrade failed");