fix(EVM): Store unpadded EVM bytecode length in versioned bytecode hash #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
requested review from
vladbochok and
StanislavBreadless
as code owners
3 tasks
0xVolosnikov
force-pushed
the
evm-emulator/change-versioned-hash-format
branch
from
37e712f to
9f23a69
Compare
0xVolosnikov
changed the base branch from
stable/evm-emulator
to
evm-emulator/fixes
0xVolosnikov
force-pushed
the
evm-emulator/change-versioned-hash-format
branch
from
0f5bd8d to
934d87f
Compare
0xVolosnikov
force-pushed
the
evm-emulator/change-versioned-hash-format
branch
from
934d87f to
32b9ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
The previously used versioned bytecode hash encoding is inefficient. For EVM contracts, we can store the length of the original unpadded EVM bytecode directly in the hash to simplify the logic of
EXTCODESIZE.Why ❔
Checklist