Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typographical errors #120

Merged
merged 1 commit into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethereum/contracts/zksync/facets/Executor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ contract ExecutorFacet is Base, IExecutor {
// carried out within the first batch committed after the upgrade.

// While the logic of the contract ensures that the s.l2SystemContractsUpgradeBatchNumber is 0 when this function is called,
// this check is added just in case. Since it is a hot read, it does not encure noticable gas cost.
// this check is added just in case. Since it is a hot read, it does not encure noticeable gas cost.
require(s.l2SystemContractsUpgradeBatchNumber == 0, "ik");

// Save the batch number where the upgrade transaction was executed.
Expand Down
2 changes: 1 addition & 1 deletion ethereum/contracts/zksync/facets/Getters.sol
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "../../common/libraries/UncheckedMath.sol";
import "../interfaces/IGetters.sol";
import "../interfaces/ILegacyGetters.sol";

/// @title Getters Contract implements functions for getting contract state from outside the batchchain.
/// @title Getters Contract implements functions for getting contract state from outside the blockchain.
/// @author Matter Labs
/// @custom:security-contact security@matterlabs.dev
contract GettersFacet is Base, IGetters, ILegacyGetters {
Expand Down
2 changes: 1 addition & 1 deletion ethereum/contracts/zksync/interfaces/ILegacyGetters.sol
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import "./IBase.sol";

/// @author Matter Labs
/// @dev This interface contains getters for the zkSync contract that should not be used,
/// but still are keot for backward compatibility.
/// but still are kept for backward compatibility.
interface ILegacyGetters is IBase {
function getTotalBlocksCommitted() external view returns (uint256);

Expand Down
6 changes: 3 additions & 3 deletions ethereum/contracts/zksync/libraries/TransactionValidator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ library TransactionValidator {
// and the size of each new encoding word).
costForComputation += Math.ceilDiv(_encodingLength * L1_TX_DELTA_544_ENCODING_BYTES, 544);

// Taking into the account the additional costs of providing new factory dependenies
// Taking into the account the additional costs of providing new factory dependencies
costForComputation += _numberOfFactoryDependencies * L1_TX_DELTA_FACTORY_DEPS_L2_GAS;

// There is a minimal amount of computational L2 gas that the transaction should cover
Expand All @@ -93,10 +93,10 @@ library TransactionValidator {

uint256 costForPubdata = 0;
{
// Adding the intrinsic cost for the transaction, i.e. auxilary prices which cannot be easily accounted for
// Adding the intrinsic cost for the transaction, i.e. auxiliary prices which cannot be easily accounted for
costForPubdata = L1_TX_INTRINSIC_PUBDATA * _l2GasPricePerPubdata;

// Taking into the account the additional costs of providing new factory dependenies
// Taking into the account the additional costs of providing new factory dependencies
costForPubdata += _numberOfFactoryDependencies * L1_TX_DELTA_FACTORY_DEPS_PUBDATA * _l2GasPricePerPubdata;
}

Expand Down
Loading