Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named mapping variables #143

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Named mapping variables #143

merged 2 commits into from
Jan 16, 2024

Conversation

StanislavBreadless
Copy link
Collaborator

What ❔

Named mapping variables

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

vladbochok
vladbochok reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@vladbochok vladbochok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add named parameters to these mappings?

mapping(address => bool) validators;
mapping(uint256 => bytes32) storedBatchHashes;
mapping(uint256 => bytes32) l2LogsRootHashes;
mapping(uint256 => mapping(uint256 => bool)) isEthWithdrawalFinalized;
``

@StanislavBreadless StanislavBreadless merged commit c200b91 into sb-short-term-fee-model Jan 16, 2024
11 of 12 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-named-mappings branch January 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok Awaiting requested review from vladbochok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanislavBreadless @vladbochok