fix: hyperchain upgrade fix2 (don't merge) #401

kelemeno · 2024-04-24T09:53:32Z

What ❔

Why ❔

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

…cts into kl/hyperchain-upgrade-fix2

l1-contracts/src.ts/hyperchain-upgrade.ts

…cts into kl/hyperchain-upgrade-fix2

…labs/era-contracts into kl/hyperchain-upgrade-fix2

…cts into kl/hyperchain-upgrade-fix2

small fixes comments

…cts into kl/hyperchain-upgrade-fix2

l1-contracts/scripts/verify.ts

l1-contracts/src.ts/hyperchain-upgrade.ts

StanislavBreadless

Discussed in private, the scripts for which the comments were left will be deleted right after the upgrade

Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>

kelemeno added 8 commits April 23, 2024 10:24

add set validator timelock

f60c7bb

add validator timelock in hyperchain

294559e

l2bridge deploy fix

49e6faa

settling l2bridge in l1bridge

d1db98e

can't set field in hardhat

5d2b08b

adding ability to print out calls

7fff94c

rename input field

7892707

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

55b38ec

…cts into kl/hyperchain-upgrade-fix2

kelemeno marked this pull request as ready for review April 24, 2024 10:36

kelemeno requested review from vladbochok and StanislavBreadless as code owners April 24, 2024 10:36

kelemeno added 4 commits April 24, 2024 11:47

lint

77ee688

separate gov operations

d593c36

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

1b3b046

…cts into kl/hyperchain-upgrade-fix2

hot wallet migration

606e581

StanislavBreadless reviewed Apr 24, 2024

View reviewed changes

l1-contracts/src.ts/hyperchain-upgrade.ts Outdated Show resolved Hide resolved

l1-contracts/src.ts/hyperchain-upgrade.ts Outdated Show resolved Hide resolved

StanislavBreadless approved these changes Apr 24, 2024

View reviewed changes

kelemeno and others added 13 commits April 24, 2024 13:51

stas comments

85bdef8

typo, remove redundunt test

f0109c4

multiple contract ver

150f647

remove extra this.

309c18e

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

f3a4618

…cts into kl/hyperchain-upgrade-fix2

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

a2d0816

…cts into kl/hyperchain-upgrade-fix2

Merge branch 'release-v23' into kl/hyperchain-upgrade-fix2

48cc997

updating migration script

24b0157

lint

9e47b3e

Merge branch 'kl/hyperchain-upgrade-fix2' of ssh://github.com/matter-…

5bc4297

…labs/era-contracts into kl/hyperchain-upgrade-fix2

base of script

262eefb

Merge branch 'release-v23' into sb-script-to-double-check

f74f4e3

check everything except for STM

46b7db3

really add validator timelock

2ba538a

kelemeno mentioned this pull request Apr 26, 2024

chore: transfer proxy admin for erc20 bridge #410

Closed

3 tasks

kelemeno added 22 commits April 26, 2024 14:01

cleaned up validator issues

dfae622

package.json

50ca803

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

54edde3

…cts into kl/hyperchain-upgrade-fix2

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

4d12199

…cts into kl/hyperchain-upgrade-fix2

stm addresses

2ecceae

more linting

76a1416

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

e1600d3

…cts into kl/hyperchain-upgrade-fix2

addresses in consistency checker and

f5b4698

small fixes comments

l2 bridge consistency constants

15ca744

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

966edd4

…cts into kl/hyperchain-upgrade-fix2

load correct beacon proxy bytecode

cdfeaeb

mainnet addresses

f792e76

easier verification for Stas

5ca6a23

nonce fix

98f960e

small changes

15948b2

lint

aebc0ce

small typo

1196a09

started reverting changes in order to merge

70fe858

some small cleaning

6b3528f

linting

47d46aa

Merge branch 'release-v23' of ssh://github.com/matter-labs/era-contra…

eb3e09e

…cts into kl/hyperchain-upgrade-fix2

fix slither

b54d20a

StanislavBreadless reviewed May 8, 2024

View reviewed changes

l1-contracts/scripts/verify.ts Outdated Show resolved Hide resolved

l1-contracts/src.ts/hyperchain-upgrade.ts Show resolved Hide resolved

l1-contracts/src.ts/hyperchain-upgrade.ts Show resolved Hide resolved

l1-contracts/src.ts/hyperchain-upgrade.ts Show resolved Hide resolved

unneeded //

8b14b9e

StanislavBreadless approved these changes May 8, 2024

View reviewed changes

kelemeno merged commit accecc4 into release-v23 May 8, 2024
21 checks passed

kelemeno deleted the kl/hyperchain-upgrade-fix2 branch May 8, 2024 14:49

Deniallugo pushed a commit that referenced this pull request Jul 25, 2024

fix: hyperchain upgrade fix2 (don't merge) (#401)

2b4c34a

Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hyperchain upgrade fix2 (don't merge) #401

fix: hyperchain upgrade fix2 (don't merge) #401

kelemeno commented Apr 24, 2024

StanislavBreadless left a comment

fix: hyperchain upgrade fix2 (don't merge) #401

fix: hyperchain upgrade fix2 (don't merge) #401

Conversation

kelemeno commented Apr 24, 2024

What ❔

Why ❔

Checklist

StanislavBreadless left a comment

Choose a reason for hiding this comment