Move gas bound caller to a separate folder #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
May 6, 2024
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
|
The CI does not pass, but it is not due to an issue in this PR: https://github.com/matter-labs/era-contracts/actions/runs/8971302673/job/24636744161?pr=446 |
vladbochok
approved these changes
May 6, 2024
Deniallugo
pushed a commit
that referenced
this pull request
Jul 25, 2024
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Moving out gas-bound caller to a separate folder:
system-contractsfolder it is neither system nor built-in and will have to be deployed manually on each chain.Important
The functionality of the GasBoundCaller has also changed a bit, now we also return the amount of gas spent on pubdata in case of a successful call
Why ❔
Checklist