remove redundant configs #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
|
|
||
| saveOutput(); | ||
| } | ||
|
|
||
| // This function should be called by the owner to accept the admin role | ||
| function acceptAdmin() public { |
There was a problem hiding this comment.
typically admin will be governance.sol contract (this is how we plan to track for upgrades), better to have a way encode a call to this contract, instead of EOA accepting admin
There was a problem hiding this comment.
I think it's doable using foundry. Thanks for noticing! as i remember we can just print the calldata
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-remove-redundant-configs
branch
4 times, most recently
from
7ada7f3
to
0115e1c
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-remove-redundant-configs
branch
from
0115e1c
to
09d01ed
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
StanislavBreadless
approved these changes
May 1, 2024
Deniallugo
force-pushed
the
deniallugo-remove-redundant-configs
branch
from
704f094
to
552da53
Compare
aon
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist