chore(verifier): update generation to include vk hash #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld-also-put-the-commitment
mm-zk
approved these changes
May 16, 2024
benceharomi
approved these changes
May 16, 2024
koloz193
deleted the
zk-evm-580-verifiersol-generation-script-should-also-put-the-commitment
branch
Yberjon
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
When a new verification key is generated we must also generate the Verifier smart contract that will validate the proofs. At the current moment when we want to verify which verification key was used to generate the smart contract we must deploy and check against the
verificationKeyHashfunction. This change auto-generates a comment at the top of the contract with the hash of the verification key used to generate the contract.Why ❔
Checklist