chore(l1-contracts): Migrate L1 Contracts to Custom Errors #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
May 17, 2024
| // SPDX-License-Identifier: MIT | ||
| pragma solidity 0.8.24; | ||
|
|
||
| error Unauthorized(address caller); |
There was a problem hiding this comment.
Better to place errors in the interface version of the contract. So we will see which error supposed to be in which contract + there will be no ridiculously big imports
There was a problem hiding this comment.
we'll likely end up with the same number of imports unless they live within the interface (but then we need to duplicate them in the tests) and a single file lets us remove duplicates. I don't feel strongly though on this.
Maybe @dnkolegov does?
vladbochok
reviewed
May 17, 2024
3 tasks
vladbochok
previously requested changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Moving all of the l1 contracts to use custom errors instead of string based reverts
pt 2 of #473
Gas Report From Before: https://gist.github.com/koloz193/c8f39f6b61411e6b6a3ddebd8a8869df
Gas Report From After: https://gist.github.com/koloz193/beb78cb4ed2aa0919d7adda72b288a07
Why ❔
Checklist