feat(contracts): add selectors to error file and update erc20 unimplemented #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vladbochok
requested changes
Jun 8, 2024
| @@ -1,20 +1,35 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.20; | |||
|
|
|||
| // 0xcbd9d2e0 | |||
There was a problem hiding this comment.
I don't see value in hardcoding it, how to check that is indeed a correct one?
There was a problem hiding this comment.
hardcoding just allows devs to quickly grep through the code and check when doing local dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
remove custom errors from unimplemented l2 erc 20 implementation and add selectors to custom error files
Why ❔
Checklist