chore(compiler): move interfaces and libraries to fpp #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Jun 8, 2024
| @@ -1,6 +1,6 @@ | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
| pragma solidity 0.8.24; | |||
| pragma solidity ^0.8.20; | |||
There was a problem hiding this comment.
Why it is ^0.8.20, and not let's say ^0.8.13? Do we use some features from 0.8.20 and higher?
There was a problem hiding this comment.
i figured this was the easiest way to avoid potential breaking changes esp given that most code bases that already needed to integrate would be on pragma 0.8.24
vladbochok
reviewed
Jun 8, 2024
…oint-pragma-for-better-usage-as-a
koloz193
deleted the
zk-evm-602-migrate-to-floating-point-pragma-for-better-usage-as-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
We want to enable devs to be able to build on top of our system and not be subject to the compiler version we use for our contracts. Moving interfaces and libraries to floating point pragmas unlocks this
Why ❔
Checklist