feat: Evm equivalence #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
requested review from
Deniallugo,
vladbochok and
StanislavBreadless
as code owners
jrchatruc
changed the title
l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol
Outdated
Show resolved
Hide resolved
* Revert fetch deployed code len optimization * Calculate hashes:fix
* Optimize EvmGasManager * Fix typo * Simplify consumeEvmFrame * Update hashes
* Remove invalid todos adding overflow checks * Remove old memory check * Add preprocessed evm interpreter * Remove unnecesary memory checks * Update hash for evm interpreter
* Revert consumeEvmFrame EvmGasManager optimization * Update hashes
jrchatruc
changed the title
* Cleanup EvmInterpreterFunctions * Cleanup in logs * Remove unneded changes * Use rawMimicCall
|
Closed in favor of #821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR includes only the necessary changes from #364 starting from the current
devbranch.The main changes are:
EvmGasManager.solandEvmInterpreter.yulcontracts were added.yarn sc preprocess:interpretercommand to preprocess the interpreter from its three template files (EvmInterpreterFunctions.template.yul,EvmInterpereterLoop.template.yulandEvmInterpreter.template.yul)CodeOraclewas updated to handle decommitments of EVM contracts (i.e. the case where theversionbyte of the code hash is2).executemethod of the DefaultAccount now checks the second byte to see if the constructor is being called and dispatches it to thecreateEVMmethod on the deployer if so.ContractDeployerhas a few more methods required for equivalence:setDeployedCode, used by the interpreter to publish evm bytecodes and store code hashescreateEVMInternaland internal functions it calls, used by the interpreter forCREATEopcodesContractDeployeralso now maintains anevmCodeHashmapping of EVM code hashes.AccountCodeStoragenow checks for EVM contracts ongetCodeHashand queries the mapping above if so.0) that thereserved1byte should be zero was removed, as it now corresponds to evm contracts.Why ❔
Checklist