fix: EVM-708 bridge fixes #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelemeno
requested review from
vladbochok and
StanislavBreadless
as code owners
Changes to gas cost
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
| function setLegacyBaseTokenAssetId(uint256 _chainId) external { | ||
| address token = baseToken[_chainId]; | ||
| require(token != address(0), "BH: token not set"); | ||
| baseTokenAssetId[_chainId] = DataEncoding.encodeNTVAssetId(block.chainid, token); |
There was a problem hiding this comment.
should be checked that the chain does not yet have the base token asset id set.
Probably reverting in case the token is set is too much (since the method is public and be frontrun), but at least not overwriting the base token should be done in case some chains have custom asset handler for base token
…a-contracts into kl/l2-legacy-bridge-splicing
| @@ -183,6 +183,19 @@ contract Bridgehub is IBridgehub, ReentrancyGuard, Ownable2StepUpgradeable, Paus | |||
| require(token != address(0), "BH: token not set"); | |||
| baseTokenAssetId[_chainId] = DataEncoding.encodeNTVAssetId(block.chainid, token); | |||
| } | |||
|
|
|||
| /// @notice Used to set the legacy chain address for the upgrade. | |||
| /// @notice This has to be used after the BH but before the STM is upgraded. | |||
There was a problem hiding this comment.
I think the comment is not correct, it has to be used after STM is upgraded, since getHyperchainLegacy is available only on the new one
|
Coverage after merging kl/l2-legacy-bridge-splicing into kl/sync-layer-reorg will be
Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist