Add PermanentRestriction tests #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yberjon
requested review from
vladbochok and
StanislavBreadless
as code owners
saxenism
approved these changes
Aug 28, 2024
| protocolVersion: 0 | ||
| }); | ||
|
|
||
| vm.expectRevert(bytes.concat("STM: owner zero")); |
There was a problem hiding this comment.
why do we have this test in the setUp?
| } | ||
|
|
||
| function test_allowAdminImplementation(bytes32 implementationHash) public { | ||
| vm.expectEmit(); |
There was a problem hiding this comment.
topics could be compared
l1-contracts/test/foundry/unit/concrete/governance/Governance/PermanentRestriction.t.sol
Outdated
Show resolved
Hide resolved
StanislavBreadless
approved these changes
Aug 30, 2024
|
I am not sure why coverage fails, I'll assume it is some CI bug and will merge |
StanislavBreadless
merged commit 5bb65c7
into
matter-labs:sb-limited-chain-amdin
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds tests for PermanentRestriction contract.