-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate L2 contracts to use foundry testing #755
Migrate L2 contracts to use foundry testing #755
Conversation
Signed-off-by: Danil <deniallugo@gmail.com>
Changes to gas cost
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
@@ -12,3 +12,6 @@ | |||
[submodule "lib/forge-std"] | |||
path = lib/forge-std | |||
url = https://github.com/foundry-rs/forge-std | |||
[submodule "lib/@matterlabs/zksync-contracts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this submodule? Looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this library for efficientcall in the l2-contracts.
We try to avoid importing stuff from node_modules
inside foundry, so we have to import it via submodule like a normal foundry lib
What ❔
Why ❔
Checklist