fix: Misleading Errors #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoffranca
requested review from
vladbochok and
StanislavBreadless
as code owners
vladbochok
reviewed
Oct 10, 2024
Comment on lines
-441
to
+442
| revert InvalidInputNodeOwnerAddress(); | ||
| revert ZeroAddress(); |
There was a problem hiding this comment.
I think that the report suggest to leave InvalidInputNodeOwnerAddress as is in this function
There was a problem hiding this comment.
Disagree. They say "The L2ContractErrors.sol file contains the ZeroAddress error declaration which can be used in both of the cases stated above."
vladbochok
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
InvalidInputNodeOwnerAddresserror with the already existingZeroAddresserror. Also deleted unused errorNodeOwnerNotFound.Fixes N-01.