Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eth_feeHistory #121

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: add eth_feeHistory #121

merged 1 commit into from
Sep 18, 2023

Conversation

MexicanAce
Copy link
Collaborator

What 💻

  • Add eth_feeHistory

Why ✋

  • This endpoint is hit by many wallets

Evidence 📷

MetaMask hitting the endpoint
image

unit tests:
image

era_test_node vs testnet:
image

image

@MexicanAce MexicanAce requested a review from a team as a code owner September 16, 2023 19:34
dutterbutter
dutterbutter approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dutterbutter dutterbutter added the approved ✅ PR is ready to be merged label Sep 18, 2023
@MexicanAce MexicanAce merged commit 270e65a into main Sep 18, 2023
9 checks passed
@MexicanAce MexicanAce deleted the nmv/add-fee-history branch September 18, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
approved ✅ PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MexicanAce @dutterbutter