Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate v24 into the test node #282

Merged
merged 7 commits into from
May 15, 2024
Merged

feat: integrate v24 into the test node #282

merged 7 commits into from
May 15, 2024

Conversation

StanislavBreadless
Copy link
Contributor

@StanislavBreadless StanislavBreadless commented Apr 30, 2024

What πŸ’»

Integrate v24 protocol version to the test node

Why βœ‹

To support the latest features including P256Verify, etc

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@StanislavBreadless StanislavBreadless requested a review from a team as a code owner April 30, 2024 11:45
@StanislavBreadless StanislavBreadless changed the title Integrate v24 into the test node feat: ntegrate v24 into the test node Apr 30, 2024
@StanislavBreadless StanislavBreadless marked this pull request as draft April 30, 2024 11:51
@StanislavBreadless StanislavBreadless changed the title feat: ntegrate v24 into the test node feat: integrate v24 into the test node May 15, 2024
@StanislavBreadless StanislavBreadless marked this pull request as ready for review May 15, 2024 10:07
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @StanislavBreadless !!!

@MexicanAce MexicanAce merged commit ae81a43 into main May 15, 2024
11 checks passed
@MexicanAce MexicanAce deleted the sb-v24-integration branch May 15, 2024 10:21
@@ -69,14 +69,34 @@
"Compressor",
"System"
],
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P256 should be here too, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EcPairing, EcAdd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants