Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: L2 gas price change #285

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

vbar
Copy link
Contributor

@vbar vbar commented May 20, 2024

What πŸ’»

Halved L2_GAS_PRICE to 25000000 and changed the fee model to match.

Why βœ‹

Replaying some Sepolia transactions didn't work with the original value.

Evidence πŸ“·

Both unit and e2e tests pass.

@vbar vbar requested a review from a team as a code owner May 20, 2024 14:49
@MexicanAce MexicanAce changed the title L2 gas price change fix: L2 gas price change May 20, 2024
@MexicanAce
Copy link
Collaborator

Thank you πŸ™ !

Confirmed that it worked for replay_tx that previously failed:

$ era_test_node replay_tx sepolia-testnet 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde 
15:38:32  INFO Creating fork from "https://sepolia.era.zksync.dev:443" L1 block: L1BatchNumber(8933) L2 block: 2327751 with timestamp 1715775538, L1 gas price 52156830537 and protocol version: Some(Version24)
15:38:32  INFO Starting network with chain id: L2ChainId(300)
15:38:32  INFO Running 1 transactions (one per batch)
15:38:32  INFO 
15:38:32  INFO Validating 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde
15:38:32  INFO Executing 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde
15:38:38  INFO β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
15:38:38  INFO β”‚   TRANSACTION SUMMARY   β”‚
15:38:38  INFO β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
15:38:38  INFO Transaction: SUCCESS
15:38:38  INFO Initiator: 0xe85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO Payer: 0xe85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO Gas - Limit: 1_919_764 | Used: 944_441 | Refunded: 975_323
15:38:38  INFO Use --show-gas-details flag or call config_setShowGasDetails to display more info
15:38:38  INFO 
15:38:38  INFO ==== Console logs: 
15:38:38  INFO 
15:38:38  INFO ==== 23 call traces.  Use --show-calls flag or call config_setShowCalls to display more info.
15:38:38  INFO 
15:38:38  INFO ==== 4 events
15:38:38  INFO EthToken System Contract                  
15:38:38  INFO   Topics:
15:38:38  INFO     0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38  INFO     0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO     0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38  INFO   Data (Hex): 0x0000000000000000000000000000000000000000000000000000534165da4324
15:38:38  INFO 
15:38:38  INFO EthToken System Contract                  
15:38:38  INFO   Topics:
15:38:38  INFO     0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38  INFO     0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38  INFO     0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO   Data (Hex): 0x000000000000000000000000000000000000000000000000000025b8ded2d2e4
15:38:38  INFO 
15:38:38  INFO EthToken System Contract                  
15:38:38  INFO   Topics:
15:38:38  INFO     0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38  INFO     0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO     0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO   Data (String): 
15:38:38  INFO 
15:38:38  INFO EthToken System Contract                  
15:38:38  INFO   Topics:
15:38:38  INFO     0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38  INFO     0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38  INFO     0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38  INFO   Data (Hex): 0x0000000000000000000000000000000000000000000000000000172204ec65f0

@MexicanAce MexicanAce merged commit d396b76 into matter-labs:main May 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants