Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double gas limit, bootloader memory layout #289

Merged
merged 4 commits into from
May 29, 2024
Merged

fix: double gas limit, bootloader memory layout #289

merged 4 commits into from
May 29, 2024

Conversation

dimazhornyk
Copy link
Contributor

@dimazhornyk dimazhornyk commented May 28, 2024 •
edited by mm-zk
Loading

What 💻

  • Fix the gas limit being added to itself
  • Fix bootloader memory layout (to match the most recent bootloader params)
  • Fix mutex usage

Why ✋

  • --show-gas-details=all was blocked by both bootloader and mutex issues
  • double gas limit was blocking the deployment of larger contracts due to going over the block gas limit

@dimazhornyk dimazhornyk requested a review from a team as a code owner May 28, 2024 15:27
@dimazhornyk dimazhornyk merged commit 1d72eae into main May 29, 2024
11 checks passed
@dimazhornyk dimazhornyk deleted the dz-fix-double-gas-limit branch May 29, 2024 08:56
@shahar4 shahar4 mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahar4 shahar4 shahar4 approved these changes

@mm-zk mm-zk mm-zk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimazhornyk @shahar4 @mm-zk