Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: procure l2 gas price when forking #290

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

zeapoz
Copy link
Contributor

@zeapoz zeapoz commented May 29, 2024

What πŸ’»

  • Automatically set the L2 fair gas price based on which network we're forking from.

Why βœ‹

Instead of having the L2 gas base price only as a constant/cli-argument, this PR introduces support for fetching the l2_fair_gas_price value within BlockDetails. This means that when forking from a network the base price will be adjusted automatically and no manual changing of the constant is necessary.

Evidence πŸ“·

image

Forking from sepolia-testnet, the L2 gas price is set to 25_000_000.

image

Forking from sepolia-testnet, this time overriding the procured gas price with --l2-gas-price=50000000.

@zeapoz zeapoz requested a review from a team as a code owner May 29, 2024 09:22
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!
LGTM

@MexicanAce MexicanAce merged commit 93946cc into matter-labs:main Jun 16, 2024
10 checks passed
@zeapoz zeapoz deleted the feat/forking-dynamic-gas-price branch June 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants