fix: added errors to internal implementation of ReadStorage #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Make functions implementing
ReadStorageforForkStoragereturnResult::Erron failure, and call them in preference to the panicking interface.Why ✋
Showing a network error is preferable to server panic.
Evidence 📷
Both unit and e2e tests pass.
Notes 📝
Unfortunately the
ReadStoragetrait cannot be removed, because it's used by zkSync Era - for a clean solution, it should be updated (so that its methods returnResult) there.