Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Treat 'run' as default command #305

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jun 27, 2024

What πŸ’»

Makes era_test_node treat run as the default subcommand.

Why βœ‹

Ergonomics and L1 compatibility. You can run anvil without any arguments, I'd expect era_test_node to do the same.

Evidence πŸ“·

image

@popzxc popzxc requested a review from a team as a code owner June 27, 2024 07:20
@MexicanAce
Copy link
Collaborator

The key difference with anvil and era-test-node is that anvil is only a Node. Where as era-test-node is also a binary to help replay transactions and help users diagnose what could've gone wrong in their code.

By default, we chose to display the help screen to better highlight that this can be more of a tool than just another node.

That being said, it sounds like there's an expectation for default functionality to first-and-foremost match anvil, so updating the default (shouldn't be) a harmful, breaking change.

Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit f8e2b97 into main Jun 27, 2024
10 checks passed
@MexicanAce MexicanAce deleted the popzxc-run-by-default branch June 27, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants