Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Run clippy in tests #306

Merged
merged 5 commits into from
Jun 27, 2024
Merged

chore: Run clippy in tests #306

merged 5 commits into from
Jun 27, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jun 27, 2024

What 💻

  • Changes make lint so that it runs clippy for tests too.
  • Fixes existing clippy warnings in test code.

Why ✋

It's harder to work with the project when you see unfixed warnings.

Evidence 📷

Self-evident.

@popzxc popzxc requested a review from a team as a code owner June 27, 2024 07:40
MexicanAce
MexicanAce approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit df89dca into main Jun 27, 2024
10 checks passed
@MexicanAce MexicanAce deleted the popzxc-clippy-in-tests branch June 27, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popzxc @MexicanAce