Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for zks_getBaseTokenL1Address. Add gas used per call in the stack #350

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

MexicanAce
Copy link
Collaborator

What 💻

  • Add support for zks_getBaseTokenL1Address
  • Add gas used per call in the stack
  • Added/fixed SUPPORTED_APIS.md for hardhat_reset

Why ✋

  • The updated Portal will not work with In-Memory Node without this endpoint
  • Having the diff gas used within the stack is useful instead of having to do mental math
  • Formatting of the table looked weird and we should include curl snippets for these commands for users to easily reference

Evidence 📷

Using the zks_getbaseTokenL1Address endpoint
image

The new gas usage diff within the call stack of era_test_node -d
image

@MexicanAce MexicanAce requested a review from a team as a code owner September 26, 2024 15:55
@MexicanAce MexicanAce merged commit 3a6451d into main Sep 26, 2024
10 checks passed
@MexicanAce MexicanAce deleted the nmv/fix-portal-integration branch September 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants