Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resync node to the latest zksync-era mirror #85

Merged
merged 17 commits into from
Aug 28, 2023
Merged

Resync node to the latest zksync-era mirror #85

merged 17 commits into from
Aug 28, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Aug 24, 2023 •
edited
Loading

What 💻

  • Syncing to the latest zksync-era mirror
  • Latest zksync-era mirror has introduced a bunch of changes in structs that we're using (like Transactions)
  • and also in the APIs (some methods were removed, others were added)
  • Also fixed all the clippy warnings about the "to_string()" calls.

Why ✋

  • We should be as up-to-date with zksync-era as possible.

Evidence 📷

image

MexicanAce
MexicanAce reviewed Aug 25, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
src/node.rs Outdated Show resolved Hide resolved
src/node.rs Outdated Show resolved Hide resolved
src/node.rs Show resolved Hide resolved
MexicanAce
MexicanAce approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mm-zk mm-zk merged commit fbff511 into main Aug 28, 2023
9 checks passed
@mm-zk mm-zk deleted the 0824_merged_to_recent branch August 28, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

@uF4No uF4No Awaiting requested review from uF4No

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mm-zk @MexicanAce