Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes avoid-contracts in favour of --skip #702

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Nov 5, 2024

Dependent on: Moonsong-Labs/compilers#39 and #698
Closes: #670

Question:

  • Should we add an alias to --skip for --avoid-contracts to avoid any breaking changes?

What 💻

  • Removes --avoid-contracts in favour of --skip

Why ✋

  • Make use of the expected foundry behaviour

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter marked this pull request as ready for review November 6, 2024 02:02
@dutterbutter dutterbutter requested a review from a team as a code owner November 6, 2024 02:02
Karrq
Karrq previously approved these changes Nov 6, 2024
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the review I was confused because I couldn't see where we now used skip, but it seems like we already supported it here.
Good stuff, this is definitely something we needed to cleanup :)

Jrigada
Jrigada previously approved these changes Nov 6, 2024
@dutterbutter dutterbutter dismissed stale reviews from Jrigada and Karrq via 6e87603 November 6, 2024 13:36
@dutterbutter
Copy link
Collaborator Author

dutterbutter commented Nov 6, 2024

@Karrq what you think re:

Should we add an alias to --skip for --avoid-contracts to avoid any breaking changes? I think aave makes use of --avoid-contracts for instance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate --avoid-contracts to --skip
3 participants