feat: switch to the default codegen with zksolc #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is in use, change readme files and add debug output
| @@ -29,8 +29,9 @@ zksolc: { | |||
| compilerPath: "zksolc", // optional. Ignored for compilerSource "docker". Can be used if compiler is located in a specific folder | |||
| libraries:{}, // optional. References to non-inlinable libraries | |||
| missingLibrariesPath: "./.zksolc-libraries-cache/missingLibraryDependencies.json" // optional. This path serves as a cache that stores all the libraries that are missing or have dependencies on other libraries. A `hardhat-zksync-deploy` plugin uses this cache later to compile and deploy the libraries, especially when the `deploy-zksync:libraries` task is executed | |||
| isSystem: false, // optional. Enables Yul instructions available only for zkSync system contracts and libraries | |||
| forceEvmla: false, // optional. Falls back to EVM legacy assembly if there is a bug with Yul | |||
| enableEraVMExtensions: false, // optional. Enables Yul instructions available only for zkSync system contracts and libraries | |||
There was a problem hiding this comment.
What we will do for the previous versions. I think we should somewhere put what was used for the previous versions.
|
|
||
| Usage of zksolc compiler version greater or equal to 1.5.0 | ||
|
|
||
| - It's necessary to set the viaYul or viaEVMAssembly flag to true at zksolc settings to specify the compiler codegen manually. |
There was a problem hiding this comment.
It is mandatory to specify the compiler codegen manually. This can be done by setting either the viaYul or viaEVMAssembly flag to true in the zksolc settings. Only one of these flags can be set to true at a time, ensuring that the code generation process is clearly defined.
| Usage of zksolc compiler version greater or equal to 1.5.0 | ||
|
|
||
| - It's necessary to set the viaYul or viaEVMAssembly flag to true at zksolc settings to specify the compiler codegen manually. | ||
| - When viaEVMAssembly is used, compiler expect only zkSync Era Solidity Compiler. |
There was a problem hiding this comment.
"compiler expect only zkSync Era Solidity Compiler" - please rephrase this part
|
|
||
| const [major, minor] = getVersionComponents(compiler.version); | ||
| if (zksolc.settings.viaYul && major === 0 && minor < 8) { | ||
| console.warn(COMPILER_ZKSOLC_NEED_EVM_CODEGEN); |
There was a problem hiding this comment.
Maybe: console.info(chalk.yellow(...
nikola-bozin-txfusion
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
itsacoyote
added a commit
to matter-labs/zksync-docs
that referenced
this pull request
Jul 3, 2024
<!-- Thank you for contributing to the ZKsync Docs! Before submitting the PR, please make sure you do the following: - Update your PR title to follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) - Read the [Contributing Guide](https://github.com/matter-labs/zksync-docs/blob/main/CONTRIBUTING.md). - Understand our [Code of Conduct](https://github.com/matter-labs/zksync-docs/blob/main/CODE_OF_CONDUCT.md) - Please delete any unused parts of the template when submitting your PR --> # Description Switches to the default codegen with the zksolc These changes with new version 1.5.0 of zksolc will affect a plugin where arguments will be sent from standard json input. ## Additional context matter-labs/hardhat-zksync#1176 matter-labs/hardhat-zksync#1062 Co-authored-by: Marko Arambasic <makiarambasic@gmail.com> Co-authored-by: Sabrina <sf@matterlabs.dev>
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Why ✋