Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to the default codegen with zksync solc #1176

Conversation

kiriyaga-txfusion
Copy link
Contributor

What 💻

  • Switches to the default codegen with the zksolc for ethers v5

Why ✋

  • These changes with new version 1.5.0 of zksolc will affect a plugin where arguments will be sent from standard json input.

@kiriyaga-txfusion kiriyaga-txfusion merged commit aaa7c75 into ethers-v5 Jun 20, 2024
7 checks passed
@kiriyaga-txfusion kiriyaga-txfusion deleted the kiriyaga-txfusion-switch-to-default-codegen-with-zksolc branch June 20, 2024 12:45
itsacoyote added a commit to matter-labs/zksync-docs that referenced this pull request Jul 3, 2024
<!--

Thank you for contributing to the ZKsync Docs!

Before submitting the PR, please make sure you do the following:

- Update your PR title to follow [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/)
- Read the [Contributing
Guide](https://github.com/matter-labs/zksync-docs/blob/main/CONTRIBUTING.md).
- Understand our [Code of
Conduct](https://github.com/matter-labs/zksync-docs/blob/main/CODE_OF_CONDUCT.md)
- Please delete any unused parts of the template when submitting your PR

-->

# Description

Switches to the default codegen with the zksolc
These changes with new version 1.5.0 of zksolc will affect a plugin
where arguments will be sent from standard json input.

## Additional context
matter-labs/hardhat-zksync#1176
matter-labs/hardhat-zksync#1062

Co-authored-by: Marko Arambasic <makiarambasic@gmail.com>
Co-authored-by: Sabrina <sf@matterlabs.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants