Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardhat-zksync-solc): support suppressed errors and warnings. #1379

Closed

Conversation

mmv08
Copy link

@mmv08 mmv08 commented Sep 12, 2024

What 💻

  • Support suppressedErrors and suppressedWarningscompiler options in hardhat-zksync-solcconfig

Why ✋

  • To compile older contracts that may've been written without EraVM in mind.

Evidence 📷

I added a test that verifies that the changes work as intended. It's currently failing because of the pending compiler fix.

Notes 📝

@mmv08 mmv08 changed the title hardhat-zksync-solc: Refactor compiler settings to support suppressed errors and warnings. feat(hardhat-zksync-solc): support suppressed errors and warnings. Sep 12, 2024
@@ -1,4 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

yarn lint
pnpm run lint
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I encountered some package manager conflict during the pre-commit hook and couldn't create a commit. It was invoking yarn, but then it'd fail with an error that the package manager used in the project is pnpm. I couldn't find yarn used anywhere in the project, so I guess pnpm is the one to use here

@kiriyaga-txfusion
Copy link
Contributor

Hey @mmv08, we’ve implemented this feature in this PR, and it’s ready for merging and release. Please check it out.

@mmv08
Copy link
Author

mmv08 commented Sep 13, 2024

hey @kiriyaga-txfusion, the PR looks good, but I'm not sure it'll work with this change: matter-labs/era-compiler-solidity#146. Perhaps it needs an update.

I like how the other PR was done under the hood, but I'm not a big fan of the user-facing part. If something can be specified as a string, I'm unsure why one must import an enum.

@kiriyaga-txfusion
Copy link
Contributor

hey @kiriyaga-txfusion, the PR looks good, but I'm not sure it'll work with this change: matter-labs/era-compiler-solidity#146. Perhaps it needs an update.

I like how the other PR was done under the hood, but I'm not a big fan of the user-facing part. If something can be specified as a string, I'm unsure why one must import an enum.

Thanks for pointing that out. The PR needs to be updated to handle changes in zksolc. I'll update the parameters to be strings so users don’t have to import anything. We’ll be releasing it this week, so stay tuned! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants