Foundry keystore #14
Merged
Foundry keystore #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MexicanAce
reviewed
May 23, 2024
Co-authored-by: Nicolas Villanueva <nicolasvillanueva@msn.com>
itsacoyote
requested changes
May 24, 2024
itsacoyote
pushed a commit
to matter-labs/zksync-docs
that referenced
this pull request
May 28, 2024
# What 💻 * Updates 101 getting started to setup a keystore * Updates all 101 Foundry tutorials to use keystore in commands to deploy/send txs * Update all commands in Foundry guide with examples of keystore use and PK. * Additionally, fixes a partial not correctly displayed in paymaster page # Why ✋ * Fixes DEVRL676 * To be merged with matter-labs/zksync-contract-templates#14 # Evidence 📷 Include screenshots, screen recordings, or `console` output here demonstrating that your changes work as intended <!-- All sections below are optional. You can uncomment any section applicable to your Pull Request. --> <!-- # Notes 📝 * Any notes/thoughts that the reviewers should know prior to reviewing the code? --> --------- Co-authored-by: Nicolas Villanueva <nicolasvillanueva@msn.com>
itsacoyote
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intendedNotes 📝