Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add zk-stack/concepts pages #20

Merged
merged 4 commits into from
Apr 22, 2024
Merged

chore: add zk-stack/concepts pages #20

merged 4 commits into from
Apr 22, 2024

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented Apr 18, 2024

What 💻

  • Add the zk-stack concepts section to the docs
  • Add Katex for math equation rendering
    • The zksync Fee Mechanism page renders math equations.

@itsacoyote itsacoyote force-pushed the zk-stack-concepts branch 2 times, most recently from 588af0c to 9d071ae Compare April 18, 2024 20:47
Base automatically changed from add-navigation to staging April 18, 2024 20:48
Copy link

github-actions bot commented Apr 18, 2024

Visit the preview URL for this PR (updated for commit cb488ce):

https://zksync-docs-staging-5eb09--pr20-zk-stack-concepts-mabyunwp.web.app

(expires Fri, 26 Apr 2024 15:41:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

@itsacoyote itsacoyote marked this pull request as ready for review April 19, 2024 15:38
@itsacoyote itsacoyote requested a review from a team as a code owner April 19, 2024 15:38
@itsacoyote
Copy link
Contributor Author

@dutterbutter There are two pages that were not listed in the navigation, I prefixed them with 99.. Not sure what to do with these.

@dutterbutter
Copy link
Contributor

dutterbutter commented Apr 22, 2024

@itsacoyote a lot of this content that is also relevant to zksync era (e.g. the articles you've flagged prefixed with 99, tx lifecycle) I think needs to be thought through more on where it should live. Will create a linear ticket to discuss but for now LGTM.

@itsacoyote itsacoyote merged commit 8fc911c into staging Apr 22, 2024
7 checks passed
@itsacoyote itsacoyote deleted the zk-stack-concepts branch April 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants